Genomeview merge debugging #1966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't believe this edge case was not caught until now. I hope this works!
The fix to skip a contig if it has a max coverage of 0 worked! But then we still ran into trouble if the max coverage was greater than zero but still not high enough to find inversions.
Another bug I ran into when running more samples - if a contig has a region of sufficient coverage, but that region isn't long enough to be considered, we want to stop looking at that contig to avoid another `TypeError: 'NoneType' object is not iterableTypeError: 'NoneType' object is not iterable` error!
… Lauren Davey for finding this bug and sharing test data :)
…lab/anvio into genomeview-merge-debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DON'T MERGE THIS PULL REQUEST WITHOUT COMPLETE CONSENSUS
This is a PR started by @isaacfink21 to save the original genome-view branch, which is in a difficult state due to some ancient git 'force' push commands. This page shall as a medium for discussions related to this merge and relevant updates, involving everyone, especially @matthewlawrenceklein and @isaacfink21 :)